Hi Bill,
Woods and the longer
irons, ie, 2,3 and 4
irons a sweeping motion is required because your hitting the ball on the up, as the ball position is nearer the front foot.
As for the shorter
clubs an upright swing is required in order to hit down on the ball as the ball position is centre of your stance.
If thinking round and up and down works. Keep doing it. Bare in mind the ball position though. Trust the club.
Good hitting.